Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update applicable .lua files to .luau #1560

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Ramdoys
Copy link

@Ramdoys Ramdoys commented Dec 9, 2024

Updates all of the APPLICABLE .lua files to the .luau file ending.

Copy link
Collaborator

@vegorov-rbx vegorov-rbx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot accept changes to the benchmark folder as that prevents comparing Luau speed to Lua/luajit (in compatible tests and tests we keep internally).

@Ramdoys Ramdoys requested a review from vegorov-rbx December 11, 2024 16:12
@Ramdoys
Copy link
Author

Ramdoys commented Dec 11, 2024

We cannot accept changes to the benchmark folder as that prevents comparing Luau speed to Lua/luajit (in compatible tests and tests we keep internally).

Should be fixed now.

@Ramdoys
Copy link
Author

Ramdoys commented Dec 22, 2024

@ccuser44 Saw you reacted with a confused emoji to my reply, anything wrong? Let me know, I am not that great at this 😭

@ccuser44
Copy link
Contributor

@ccuser44 Saw you reacted with a confused emoji to my reply, anything wrong? Let me know, I am not that great at this 😭

Thought you didnt fully fix the issue with Vanilla with the pull but wasnt sure

I now checked again and realised it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants